Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queue channel name color for some devices #3822

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Jun 27, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

For some reason a strange style attribute was used for title and channel in background/popup queues. This caused some problems on some devices. So I removed the style attributes from the TextViews and added textAppearance, with the same values used in fragment_video_detail for, respectively, title and description.

Fixes the following issue(s)

Testing apk

@xxkfqz @primarto please test if this fixes the issue, thank you in advance ;-)
app-debug.zip

Agreement

@Stypox Stypox added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Jun 27, 2020
@xxkfqz
Copy link
Contributor

xxkfqz commented Jun 28, 2020

I think the bug is fixed, thanks!
1
2
3

@TobiGr TobiGr added this to the 0.19.6 milestone Jun 30, 2020
@TobiGr TobiGr merged commit d0b5345 into TeamNewPipe:dev Jun 30, 2020
This was referenced Jul 8, 2020
@Stypox Stypox deleted the fix-queue-colors branch August 4, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong colors in channel name in background player
3 participants